[netatmo] The lastEvent is detected/compared incorrectly (#7963) #7964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sven Strohschein <[email protected]>
|
I will also add some tests for NAWelcomeHomeHandler so such a mistake can't occur again. I didn't detected the error and the code-review was also not enough. ;-) Please review this pull-request soon because the bug shouldn't go productive with 2.5.6. |
Travis tests were successfulHey @Novanic, |
1 similar comment
Travis tests were successfulHey @Novanic, |
Signed-off-by: Sven Strohschein <[email protected]>
cpmeister
added
the
bug
|
Hey @Novanic, TravisCI finished with status TravisBuddy Request Identifier: 75b14000-b344-11ea-894e-97d5968798bd |
knikhilwiz
pushed a commit
to knikhilwiz/openhab2-addons
that referenced
this pull request
Jul 12, 2020
… (openhab#7964) * Bug-fix - The last event wasn't detected/compared correctly... * Tests regarding lastEvent added Signed-off-by: Sven Strohschein <[email protected]>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
… (openhab#7964) * Bug-fix - The last event wasn't detected/compared correctly... * Tests regarding lastEvent added Signed-off-by: Sven Strohschein <[email protected]> Signed-off-by: CSchlipp <[email protected]>
MPH80
pushed a commit
to MPH80/openhab-addons
that referenced
this pull request
Aug 3, 2020
… (openhab#7964) * Bug-fix - The last event wasn't detected/compared correctly... * Tests regarding lastEvent added Signed-off-by: Sven Strohschein <[email protected]> Signed-off-by: MPH80 <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
… (openhab#7964) * Bug-fix - The last event wasn't detected/compared correctly... * Tests regarding lastEvent added Signed-off-by: Sven Strohschein <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
… (openhab#7964) * Bug-fix - The last event wasn't detected/compared correctly... * Tests regarding lastEvent added Signed-off-by: Sven Strohschein <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
… (openhab#7964) * Bug-fix - The last event wasn't detected/compared correctly... * Tests regarding lastEvent added Signed-off-by: Sven Strohschein <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
… (openhab#7964) * Bug-fix - The last event wasn't detected/compared correctly... * Tests regarding lastEvent added Signed-off-by: Sven Strohschein <[email protected]>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
… (openhab#7964) * Bug-fix - The last event wasn't detected/compared correctly... * Tests regarding lastEvent added Signed-off-by: Sven Strohschein <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
… (openhab#7964) * Bug-fix - The last event wasn't detected/compared correctly... * Tests regarding lastEvent added Signed-off-by: Sven Strohschein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #7963 . The bug exists since 2.5.6 and should get solved immediately with 2.5.6.